Issue 2972063002: fix completion test expectation for fasta scanner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2972063002: fix completion test expectation for fasta scanner (Closed)

Created:
3 years, 5 months ago by danrubel

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix completion test expectation for fasta scanner Committed: https://github.com/dart-lang/sdk/commit/8cca31711854212f34e24ab1d381c56b711a06e8

Patch Set 1 #

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pkg/analyzer_plugin/test/src/utilities/completion/completion_target_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

danrubel

Committed patchset #1 (id:1) manually as 8cca31711854212f34e24ab1d381c56b711a06e8 (presubmit successful).

3 years, 5 months ago (2017-07-06 18:08:01 UTC) #4

Brian Wilkerson

3 years, 5 months ago (2017-07-06 18:14:21 UTC) #5

Message was sent while issue was closed.

From a casual glance, it looks like analyzer is recovering by adding a synthetic
entry with a synthetic key and synthetic value (simple identifiers). I didn't
look at the code, only the test, so I might be wrong. If so, this gives code
completion something to complete from.

As long as completion will work inside an empty map literal (which I assume it
does), this seems like a reasonable change. lgtm.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages