Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: docs/speed/perf_regression_sheriffing.md

Issue 2972043002: Remove documentation on stoppage alerts. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | docs/speed/triaging_data_stoppage_alerts.md » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Perf Regression Sheriffing (go/perfregression-sheriff) 1 # Perf Regression Sheriffing (go/perfregression-sheriff)
2 2
3 The perf regression sheriff tracks performance regressions in Chrome's 3 The perf regression sheriff tracks performance regressions in Chrome's
4 continuous integration tests. Note that a [new rotation](perf_bot_sheriffing.md) 4 continuous integration tests. Note that a [new rotation](perf_bot_sheriffing.md)
5 has been created to ensure the builds and tests stay green, so the perf 5 has been created to ensure the builds and tests stay green, so the perf
6 regression sheriff role is now entirely focused on performance. 6 regression sheriff role is now entirely focused on performance.
7 7
8 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)** 8 **[Rotation calendar](https://calendar.google.com/calendar/embed?src=google.com_ 2fpmo740pd1unrui9d7cgpbg2k%40group.calendar.google.com)**
9 9
10 ## Key Responsibilities 10 ## Key Responsibilities
11 11
12 * [Triage Regressions on the Perf Dashboard](#Triage-Regressions-on-the-Perf-Da shboard) 12 * [Triage Regressions on the Perf Dashboard](#Triage-Regressions-on-the-Perf-Da shboard)
13 * [Triaging Data Stoppage Alerts](#Triaging-Data-Stoppage-Alerts)
14 * [Follow up on Performance Regressions](#Follow-up-on-Performance-Regressions) 13 * [Follow up on Performance Regressions](#Follow-up-on-Performance-Regressions)
15 * [Give Feedback on our Infrastructure](#Give-Feedback-on-our-Infrastructure) 14 * [Give Feedback on our Infrastructure](#Give-Feedback-on-our-Infrastructure)
16 15
17 ## Triage Regressions on the Perf Dashboard 16 ## Triage Regressions on the Perf Dashboard
18 17
19 Open the perf dashboard [alerts page](https://chromeperf.appspot.com/alerts). 18 Open the perf dashboard [alerts page](https://chromeperf.appspot.com/alerts).
20 19
21 In the upper right corner, **sign in with your Chromium account**. Signing in is 20 In the upper right corner, **sign in with your Chromium account**. Signing in is
22 important in order to be able to kick off bisect jobs, and see data from 21 important in order to be able to kick off bisect jobs, and see data from
23 internal waterfalls. 22 internal waterfalls.
24 23
25 Pick up **Chromium Perf Sheriff** from "Select an item ▼" drop down menu. There 24 Pick up **Chromium Perf Sheriff** from "Select an item ▼" drop down menu.
26 are two tables of alerts that may be shown: 25 table of "Performance Alerts" should be shown. If there are no currently pending
27 26 alerts, then the table won't be shown.
28 * "Performance Alerts"
29 * "Data Stoppage Alerts"
30
31 For either type of alert, if there are no currently pending alerts, then the
32 table won't be shown.
33 27
34 The list can be sorted by clicking on the column header. When you click on the 28 The list can be sorted by clicking on the column header. When you click on the
35 checkbox next to an alert, all the other alerts that occurred in the same 29 checkbox next to an alert, all the other alerts that occurred in the same
36 revision range will be highlighted. 30 revision range will be highlighted.
37 31
38 Check the boxes next to the alerts you want to take a look at, and click the 32 Check the boxes next to the alerts you want to take a look at, and click the
39 "Graph" button. You'll be taken to a page with a table at the top listing all 33 "Graph" button. You'll be taken to a page with a table at the top listing all
40 the alerts that have an overlapping revision range with the one you chose, and 34 the alerts that have an overlapping revision range with the one you chose, and
41 below it the dashboard shows graphs of all the alerts checked in that table. 35 below it the dashboard shows graphs of all the alerts checked in that table.
42 36
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 tooltip on the graph. If you see any likely culprits, cc the authors on the 68 tooltip on the graph. If you see any likely culprits, cc the authors on the
75 bug. 69 bug.
76 6. **Optionally, kick off more bisects**. The perf dashboard will automatically 70 6. **Optionally, kick off more bisects**. The perf dashboard will automatically
77 kick off a bisect for each bug you file. But if you think the regression is 71 kick off a bisect for each bug you file. But if you think the regression is
78 much clearer on one platform, or a specific page of a page set, or you want 72 much clearer on one platform, or a specific page of a page set, or you want
79 to see a broader revision range feel free to click on the alert on that graph 73 to see a broader revision range feel free to click on the alert on that graph
80 and kick off a bisect for it. There should be capacity to kick off as many 74 and kick off a bisect for it. There should be capacity to kick off as many
81 bisects as you feel are necessary to investigate; [give feedback](#feedback) 75 bisects as you feel are necessary to investigate; [give feedback](#feedback)
82 below if you feel that is not the case. 76 below if you feel that is not the case.
83 77
84 ## Triaging Data Stoppage Alerts
85
86 Data stoppage alerts are listed on the
87 [perf dashboard alerts page](https://chromeperf.appspot.com/alerts). Whenever
88 the dashboard is monitoring a metric, and that metric stops sending data, an
89 alert is fired. See
90 [triaging data stoppage alerts](triaging_data_stoppage_alerts.md) for more
91 details.
92
93 ## Follow up on Performance Regressions 78 ## Follow up on Performance Regressions
94 79
95 During your shift, you should try to follow up on each of the bugs you filed. 80 During your shift, you should try to follow up on each of the bugs you filed.
96 Once you've triaged all the alerts, check to see if the bisects have come back, 81 Once you've triaged all the alerts, check to see if the bisects have come back,
97 or if they failed. If the results came back, and a culprit was found, follow up 82 or if they failed. If the results came back, and a culprit was found, follow up
98 with the CL author. If the bisects failed to update the bug with results, please 83 with the CL author. If the bisects failed to update the bug with results, please
99 file a bug on it (see [feedback](#feedback) links below). 84 file a bug on it (see [feedback](#feedback) links below).
100 85
101 Also during your shift, please spend any spare time driving down bugs from the 86 Also during your shift, please spend any spare time driving down bugs from the
102 [regression backlog](http://go/triage-backlog). Treat these bugs as you would 87 [regression backlog](http://go/triage-backlog). Treat these bugs as you would
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 [go/bad-bisects](https://docs.google.com/spreadsheets/d/13PYIlRGE8eZzsrSocA3SR 2LEHdzc8n9ORUoOE2vtO6I/edit#gid=0). 120 [go/bad-bisects](https://docs.google.com/spreadsheets/d/13PYIlRGE8eZzsrSocA3SR 2LEHdzc8n9ORUoOE2vtO6I/edit#gid=0).
136 The team triages these regularly. If you spot a really clear bug (bisect 121 The team triages these regularly. If you spot a really clear bug (bisect
137 job red, bugs not being updated with bisect results) please file it in 122 job red, bugs not being updated with bisect results) please file it in
138 crbug with component `Speed>Bisection`. If a bisect problem is blocking a 123 crbug with component `Speed>Bisection`. If a bisect problem is blocking a
139 perf regression bug triage, **please file a new bug with component 124 perf regression bug triage, **please file a new bug with component
140 `Speed>Bisection` and block the regression bug on the bisect bug**. This 125 `Speed>Bisection` and block the regression bug on the bisect bug**. This
141 makes it much easier for the team to triage, dupe, and close bugs on the 126 makes it much easier for the team to triage, dupe, and close bugs on the
142 infrastructure without affecting the state of the perf regression bugs. 127 infrastructure without affecting the state of the perf regression bugs.
143 * **Noisy Tests**: Please file a bug in crbug with component `Speed>Benchmarks` 128 * **Noisy Tests**: Please file a bug in crbug with component `Speed>Benchmarks`
144 and [cc the owner](http://go/perf-owners). 129 and [cc the owner](http://go/perf-owners).
OLDNEW
« no previous file with comments | « no previous file | docs/speed/triaging_data_stoppage_alerts.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698