Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 297203002: Skip write barriers in the fast case when setting up local context. (Closed)

Created:
6 years, 7 months ago by Benedikt Meurer
Modified:
6 years, 7 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Skip write barriers in the fast case when setting up local context. The FastNewContextStub always allocates in new space, so we don't need to update the write barrier when copying the parameters to the newly allocated context. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21481

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -26 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +17 lines, -7 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 3 chunks +15 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 7 months ago (2014-05-24 12:24:31 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 7 months ago (2014-05-26 08:12:20 UTC) #2
Benedikt Meurer
6 years, 7 months ago (2014-05-26 08:13:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698