Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc

Issue 2972003002: RTCPeerConnection.ontrack event added. (Closed)
Patch Set: Le merge Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc b/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc
index f93585016a40b8ba36829471cb6505aee3e20639..ad1c6bd792d85b50f40f0f2eaea6e00524eaa335 100644
--- a/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_rtp_browsertest.cc
@@ -72,6 +72,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcRtpBrowserTest, AddAndRemoveTracksWithoutStream) {
SetupPeerconnectionWithoutLocalStream(left_tab_);
SetupPeerconnectionWithoutLocalStream(right_tab_);
+ SetupOnTrackListener(right_tab_);
// TODO(hbos): Here and in other "AddAndRemoveTracks" tests: when ontrack and
// ended events are supported, verify that these are fired on the remote side
@@ -109,6 +110,15 @@ IN_PROC_BROWSER_TEST_F(WebRtcRtpBrowserTest, AddAndRemoveTracksWithoutStream) {
EXPECT_TRUE(HasReceiverWithTrack(right_tab_, audio_track_id));
EXPECT_TRUE(HasReceiverWithTrack(right_tab_, video_track_id));
VerifyRtpReceivers(right_tab_, 2);
+ std::vector<TrackEvent> track_events = GetTrackEvents(right_tab_);
+ for (TrackEvent& track_event : track_events) {
+ printf("HBOS: track_id: %s", track_event.track_id.c_str());
+ if (!track_event.stream_ids.empty()) {
+ for (std::string& stream_id : track_event.stream_ids)
+ printf(" %s", stream_id.c_str());
+ }
+ printf("\n");
+ }
// Remove first track.
RemoveTrack(left_tab_, audio_track_id);
@@ -148,6 +158,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcRtpBrowserTest,
SetupPeerconnectionWithoutLocalStream(left_tab_);
SetupPeerconnectionWithoutLocalStream(right_tab_);
+ SetupOnTrackListener(right_tab_);
// Add two tracks.
EXPECT_EQ(0u, GetNegotiationNeededCount(left_tab_));
@@ -224,6 +235,7 @@ IN_PROC_BROWSER_TEST_F(WebRtcRtpBrowserTest,
SetupPeerconnectionWithoutLocalStream(left_tab_);
SetupPeerconnectionWithoutLocalStream(right_tab_);
+ SetupOnTrackListener(right_tab_);
// Add two tracks.
EXPECT_EQ(0u, GetNegotiationNeededCount(left_tab_));
« no previous file with comments | « chrome/browser/media/webrtc/webrtc_browsertest_base.cc ('k') | chrome/test/data/webrtc/peerconnection_rtp.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698