Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java

Issue 2971953002: Skip TabObserver#onUrlUpdated when not in main frame (Closed)
Patch Set: merge blocks Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
index efea41c3cb5074b1c206324391183cca08fba665..10dc0175b0b8ea7701a2eb622d34ecf873e61a0a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
@@ -231,11 +231,11 @@ public class TabWebContentsObserver extends WebContentsObserver {
mTab.updateTitle();
mTab.handleDidFinishNavigation(url, pageTransition);
mTab.setIsShowingErrorPage(isErrorPage);
- }
- observers.rewind();
- while (observers.hasNext()) {
- observers.next().onUrlUpdated(mTab);
+ observers.rewind();
+ while (observers.hasNext()) {
+ observers.next().onUrlUpdated(mTab);
+ }
}
FullscreenManager fullscreenManager = mTab.getFullscreenManager();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698