Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 297193005: Fix path tracer test. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix path tracer test. Path tracer is not compatible with --enable-slow-assert. R=mstarzinger@chromium.org BUG=v8:3350 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21542

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M test/cctest/cctest.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-05-27 14:17:28 UTC) #1
Michael Starzinger
This CL seems to contain several changes smashed together ... could you re-upload just the ...
6 years, 7 months ago (2014-05-27 14:31:52 UTC) #2
Michael Starzinger
LGTM.
6 years, 7 months ago (2014-05-27 14:34:41 UTC) #3
Yang
6 years, 6 months ago (2014-05-28 06:42:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21542 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698