Issue 297193003: New avatar menu: Add icon for supervised users.

Issue 297193003: New avatar menu: Add icon for supervised users. (Closed)

Created:
6 years, 7 months ago by Marc Treib

Modified:
6 years, 6 months ago

Reviewers:
msw, oshima

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

New avatar menu: Add icon for supervised users. Mock: https://folio.googleplex.com/chrome-ux/mocks/064-chrome-away-from-chrome/supervised/mirror#%2FPlaypen_210514_mirror-05.png BUG=372812, 310640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274508

Patch Set 3 : New resources #

Total comments: 3

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -0 lines)			Patch
A	chrome/app/theme/default_100_percent/common/avatar_menu_supervised.png	View	1 2	Binary file		0 comments	Download
A	chrome/app/theme/default_200_percent/common/avatar_menu_supervised.png	View	1 2	Binary file		0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm	View	1 2	1 chunk	+14 lines, -0 lines	2 comments	Download
M	chrome/browser/ui/views/profiles/profile_chooser_view.cc	View	1 2	1 chunk	+15 lines, -0 lines	1 comment	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Marc Treib

Hi Mike, I'm still waiting for the new icon asset here, but since this is ...

6 years, 7 months ago (2014-05-27 09:21:15 UTC) #1

Marc Treib

I got the new resources now, and added them to this CL. Adding oshima@ for ...

6 years, 6 months ago (2014-06-02 14:22:52 UTC) #2

msw

lgtm with nits. https://codereview.chromium.org/297193003/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/297193003/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1256 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1256: base::scoped_nsobject<NSImageView> supervisedIcon( nit: it'd be nice ...

6 years, 6 months ago (2014-06-02 21:18:14 UTC) #4

Marc Treib

https://codereview.chromium.org/297193003/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right): https://codereview.chromium.org/297193003/diff/80001/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm#newcode1256 chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:1256: base::scoped_nsobject<NSImageView> supervisedIcon( On 2014/06/02 21:18:15, msw wrote: > nit: ...

6 years, 6 months ago (2014-06-03 08:26:02 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/297193003/80001

6 years, 6 months ago (2014-06-03 08:27:15 UTC) #7

Message was sent while issue was closed.

Change committed as 274508

Expand Messages | Collapse Messages