Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 297193002: Cleanup: Remove unused bits of TestingProfile. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove unused bits of TestingProfile. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273051

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M chrome/test/base/testing_profile.h View 4 chunks +0 lines, -16 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-24 07:00:56 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-05-26 14:02:34 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-27 05:40:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297193002/40001
6 years, 7 months ago (2014-05-27 05:40:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 07:23:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 07:27:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77783)
6 years, 7 months ago (2014-05-27 07:27:15 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-27 17:02:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297193002/40001
6 years, 7 months ago (2014-05-27 17:03:38 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 17:29:36 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 17:37:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/78008)
6 years, 7 months ago (2014-05-27 17:37:45 UTC) #12
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-27 21:13:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/297193002/40001
6 years, 7 months ago (2014-05-27 21:17:39 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 22:17:34 UTC) #15
Message was sent while issue was closed. 
Change committed as 273051

Powered by Google App Engine
This is Rietveld 408576698