Issue 2971903006: Add fileEndOffset to Class.

Issue 2971903006: Add fileEndOffset to Class. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
jensj, ahe, Siggi Cherem (dart-lang), Kevin Millikin (Google), Paul Berry

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -0 lines)			Patch
M	pkg/kernel/binary.md	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/kernel/lib/ast.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_from_binary.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/kernel/lib/binary/ast_to_binary.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/kernel_binary_flowgraph.h	View	3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

ahe

LGTM I'm always a little bit uncomfortable reviewing C++, but with our coverage on build ...

3 years, 5 months ago (2017-07-06 16:54:26 UTC) #3

scheglov

Committed patchset #1 (id:1) manually as 09a5d31ec4a61739bcedf95b29732d860fffd41c (presubmit successful).

3 years, 5 months ago (2017-07-06 17:28:13 UTC) #5

Message was sent while issue was closed.

lgtm