Adding error handling to the connection flow.

remoting/client/chromoting_session.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/chromoting_session.h"
 
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 259 matching lines @@
   logger_->LogSessionStateChange(ClientTelemetryLogger::TranslateState(state),
                                  ClientTelemetryLogger::TranslateError(error));
 
   if (create_pairing_ && state == protocol::ConnectionToHost::CONNECTED) {
     protocol::PairingRequest request;
     DCHECK(!device_name_.empty());
     request.set_client_name(device_name_);
     client_->host_stub()->RequestPairing(request);
   }
 
+  if (state == protocol::ConnectionToHost::FAILED) {
+    remoting::SignalStrategy::Error err = signaling_->GetError();

[Yuwei, 2017/07/05 21:43:41]

Where is err used?

[nicholss, 2017/07/06 20:49:01]

Sorry, this was debug, I had already removed it in patch 3.

+  }
+
   runtime_->ui_task_runner()->PostTask(
       FROM_HERE, base::Bind(&ChromotingSession::Delegate::OnConnectionState,
                             delegate_, state, error));
 }
 
 void ChromotingSession::OnConnectionReady(bool ready) {
   // We ignore this message, since OnConnectionState tells us the same thing.
 }
 
 void ChromotingSession::OnRouteChanged(const std::string& channel_name,
@@ skipping 159 matching lines @@
   video_renderer_.reset();
   signaling_.reset();
   perf_tracker_.reset();
   client_context_.reset();
   cursor_shape_stub_.reset();
 
   weak_factory_.InvalidateWeakPtrs();
 }
 
 }  // namespace remoting