Issue 2971893002: Remove other usages of ExecutableElement.localVariables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2971893002: Remove other usages of ExecutableElement.localVariables. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove other usages of ExecutableElement.localVariables. Use AST to find LocalVariableElement(s), don't test for empty. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ee177cb51ebce624a3862c67a6fef51b4eecf26d

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+114 lines, -196 lines)			Patch
M	pkg/analyzer/test/dart/element/builder_test.dart	View	37 chunks	+102 lines, -144 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	pkg/analyzer/test/generated/strong_mode_test.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/search_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/src/dart/element/element_test.dart	View	1 chunk	+1 line, -37 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	2 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 5 months ago (2017-07-05 21:33:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee177cb51ebce624a3862c67a6fef51b4eecf26d (presubmit successful).