Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.cc

Issue 297183010: Remove BrowserPluginGuestDelegate::GuestProcessGone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/web_view_guest.cc
diff --git a/chrome/browser/guest_view/web_view/web_view_guest.cc b/chrome/browser/guest_view/web_view/web_view_guest.cc
index 3286f09b41a09e63a7dd305bf6e59110523b3ef6..ae77819af6cd586d019476d25239da264f4e87cd 100644
--- a/chrome/browser/guest_view/web_view/web_view_guest.cc
+++ b/chrome/browser/guest_view/web_view/web_view_guest.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/guest_view/web_view/web_view_guest.h"
-#include "base/debug/stack_trace.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
@@ -430,17 +429,6 @@ void WebViewGuest::FindReply(WebContents* source,
active_match_ordinal, final_update);
}
-void WebViewGuest::GuestProcessGone(base::TerminationStatus status) {
- // Cancel all find sessions in progress.
- find_helper_.CancelAllFindSessions();
-
- scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- args->SetInteger(webview::kProcessId,
- guest_web_contents()->GetRenderProcessHost()->GetID());
- args->SetString(webview::kReason, TerminationStatusToString(status));
- DispatchEvent(new GuestViewBase::Event(webview::kEventExit, args.Pass()));
-}
-
void WebViewGuest::HandleKeyboardEvent(
WebContents* source,
const content::NativeWebKeyboardEvent& event) {
@@ -876,6 +864,17 @@ bool WebViewGuest::OnMessageReceived(const IPC::Message& message,
return handled;
}
+void WebViewGuest::RenderProcessGone(base::TerminationStatus status) {
+ // Cancel all find sessions in progress.
+ find_helper_.CancelAllFindSessions();
+
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ args->SetInteger(webview::kProcessId,
+ guest_web_contents()->GetRenderProcessHost()->GetID());
+ args->SetString(webview::kReason, TerminationStatusToString(status));
+ DispatchEvent(new GuestViewBase::Event(webview::kEventExit, args.Pass()));
+}
+
void WebViewGuest::WebContentsDestroyed() {
// Clean up custom context menu items for this guest.
extensions::MenuManager* menu_manager = extensions::MenuManager::Get(
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_guest.h ('k') | content/browser/browser_plugin/browser_plugin_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698