Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4238)

Unified Diff: chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js

Issue 2971823002: Cleanup Tool WebUI: Add logs upload checkbox and minor polishing (Closed)
Patch Set: Minor fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
diff --git a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
index b032a5cdd05601bab5d9b34f8c6139fa2a93888b..8b229e29ba4fd4a3f26f588d51419de9ffa8d002 100644
--- a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
+++ b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_proxy.js
@@ -13,8 +13,9 @@ cr.define('settings', function() {
/**
* Starts a cleanup on the user's computer.
+ * @param {boolean} logs_upload_enabled
*/
- startCleanup() {}
+ startCleanup(logs_upload_enabled) {}
ftirelo 2017/07/05 19:02:25 Nit: shouldn't this be logsUploadEnabled ?
proberge 2017/07/05 20:14:20 Done.
/**
* Restarts the user's computer.
@@ -25,6 +26,12 @@ cr.define('settings', function() {
* Hides the Cleanup page from the settings menu.
*/
dismissCleanupPage() {}
+
+ /**
+ * Updates the cleanup logs upload permission status.
+ * @param {boolean} enabled
+ */
+ setLogsUploadPermission(enabled) {}
}
/**
@@ -37,8 +44,8 @@ cr.define('settings', function() {
}
/** @override */
- startCleanup() {
- chrome.send('startCleanup');
+ startCleanup(logs_upload_enabled) {
+ chrome.send('startCleanup', [logs_upload_enabled]);
}
/** @override */
@@ -50,6 +57,11 @@ cr.define('settings', function() {
dismissCleanupPage() {
chrome.send('dismissCleanupPage');
}
+
+ /** @override */
+ setLogsUploadPermission(enabled) {
+ chrome.send('setLogsUploadPermission', [enabled]);
+ }
}
cr.addSingletonGetter(ChromeCleanupProxyImpl);

Powered by Google App Engine
This is Rietveld 408576698