Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html

Issue 2971823002: Cleanup Tool WebUI: Add logs upload checkbox and minor polishing (Closed)
Patch Set: Minor fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
diff --git a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
index 3457c8af4549b7adabf31599869851751799e6a8..202016c56a0be4feda3ca23d5f255408a777a23d 100644
--- a/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
+++ b/chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
@@ -14,14 +14,20 @@
<dom-module id="settings-chrome-cleanup-page">
<template>
<style include="settings-shared">
+ #about-link {
+ color: var(--paper-blue-700);
+ text-decoration: none;
+ }
+
#files-to-remove-list {
-webkit-user-select: text;
word-break: break-all;
}
#show-files-button {
- color: var(--google-blue-700);
--paper-button-ink-color: white;
+ -webkit-margin-start: calc(var(--settings-button-edge-spacing) * -1);
ftirelo 2017/07/05 19:02:25 Please describe why you need this incantation.
proberge 2017/07/05 20:14:20 Done.
+ color: var(--google-blue-700);
text-transform: inherit;
}
@@ -31,8 +37,8 @@
}
.status-icon-container {
+ -webkit-padding-end: 12px;
min-width: 28px;
- padding-right: 12px;
}
.status-icon-remove {
@@ -68,9 +74,22 @@
</div>
<div id="details-container"
class="settings-box two-line" hidden="[[!showDetails_]]">
- <div>[[detailsDescription]]</div>
+ <div>
+ $i18n{chromeCleanupExplanation}
+ <a href="$i18n{chromeCleanupLearnMoreUrl}" target="_blank">
+ $i18n{learnMore}
+ </a>
+ </div>
+ </div>
+ <div class="settings-box continuation" hidden="[[!showLogsPermission_]]">
+ <settings-toggle-button class="start"
+ id="logsUploadControl"
ftirelo 2017/07/05 19:02:25 Nit: chromeCleanupLogsUploadControl just to be uni
proberge 2017/07/05 20:14:20 Done.
+ label="$i18n{chromeCleanupLogsUploadPermission}"
+ pref="[[logsUploadPref_]]"
+ on-settings-boolean-control-change="changeLogsPermission_">
+ </settings-toggle-button>
</div>
- <div class="settings-box continuation" hidden="[[!showDetails_]]">
+ <div class="settings-box" hidden="[[!showDetails_]]">
<div class="show-files-container start" hidden="[[showFilesToRemove_]]">
<paper-button id="show-files-button" on-tap="showFiles_">
$i18n{chromeCleanupLinkShowFiles}

Powered by Google App Engine
This is Rietveld 408576698