Cleanup Tool WebUI: Add logs upload checkbox and minor polishing

chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc

 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/chrome_cleanup_handler.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
@@ skipping 57 matching lines @@
       base::Bind(&ChromeCleanupHandler::HandleDismiss, base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "registerChromeCleanerObserver",
       base::Bind(&ChromeCleanupHandler::HandleRegisterChromeCleanerObserver,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
       "restartComputer",
       base::Bind(&ChromeCleanupHandler::HandleRestartComputer,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback(
+      "setLogsUploadPermission",
+      base::Bind(&ChromeCleanupHandler::HandleSetLogsUploadPermission,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
       "startCleanup", base::Bind(&ChromeCleanupHandler::HandleStartCleanup,
                                  base::Unretained(this)));
 }
 
 void ChromeCleanupHandler::OnJavascriptAllowed() {
   controller_->AddObserver(this);
 }
 
 void ChromeCleanupHandler::OnJavascriptDisallowed() {
   controller_->RemoveObserver(this);
@@ skipping 21 matching lines @@
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::Value("chrome-cleanup-on-cleaning"),
                          GetFilesAsListStorage(files));
 }
 
 void ChromeCleanupHandler::OnRebootRequired() {
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::Value("chrome-cleanup-on-reboot-required"));
 }
 
+void ChromeCleanupHandler::OnLogsEnabledChanged(bool logs_enabled) {
+  CallJavascriptFunction("cr.webUIListenerCallback",
+                         base::Value("chrome-cleanup-upload-permission-change"),
+                         base::Value(logs_enabled));
+}
+
 void ChromeCleanupHandler::HandleDismiss(const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
 
   controller_->RemoveObserver(this);
 
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::Value("chrome-cleanup-on-dismiss"));
 }
 
 void ChromeCleanupHandler::HandleRegisterChromeCleanerObserver(
     const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
   // The Polymer element should never be attached if the feature is
   // disabled.
   DCHECK(
       base::FeatureList::IsEnabled(safe_browsing::kInBrowserCleanerUIFeature));
 
   AllowJavascript();
+
+  // Send the current logs upload state.
+  OnLogsEnabledChanged(controller_->logs_enabled());
 }
 
 void ChromeCleanupHandler::HandleRestartComputer(const base::ListValue* args) {
   DCHECK_EQ(0U, args->GetSize());
 
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::Value("chrome-cleanup-on-dismiss"));
-  // TODO(proberge): Show a prompt to reboot the system.
+
+  controller_->Reboot();
+}
+
+void ChromeCleanupHandler::HandleSetLogsUploadPermission(
+    const base::ListValue* args) {
+  CHECK_EQ(1U, args->GetSize());

[ftirelo, 2017/07/05 19:02:25]

CHECK_EQ -> DCHECK_EQ

We use DCHECK in other arg list validations.

[proberge, 2017/07/05 20:14:20]

Here the param is actually strictly needed.

+  bool allow_logs_upload = false;
+  args->GetBoolean(0, &allow_logs_upload);
+
+  controller_->SetLogsEnabled(allow_logs_upload);
 }
 
 void ChromeCleanupHandler::HandleStartCleanup(const base::ListValue* args) {
-  DCHECK_EQ(0U, args->GetSize());
+  CHECK_EQ(1U, args->GetSize());

[ftirelo, 2017/07/05 19:02:25]

Ditto.

[proberge, 2017/07/05 20:14:20]

Ditto^2

+  bool allow_logs_upload = false;
+  args->GetBoolean(0, &allow_logs_upload);
+
+  // The state is propagated to all open tabs and should be consistent.
+  DCHECK_EQ(controller_->logs_enabled(), allow_logs_upload);
 
   controller_->ReplyWithUserResponse(
-      // TODO(proberge): Send kAcceptedWithLogs or kAcceptedWithoutLogs based on
-      // the state of a logs upload permissions checkbox.
-      profile_, ChromeCleanerController::UserResponse::kAcceptedWithoutLogs);
+      profile_,
+      allow_logs_upload
+          ? ChromeCleanerController::UserResponse::kAcceptedWithLogs
+          : ChromeCleanerController::UserResponse::kAcceptedWithoutLogs);
 }
 
 }  // namespace settings