Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 2971783002: Skeleton for showing "Show all saved passwords row" for Linux/CrOs/Windows platforms (Closed)
Patch Set: . Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/chrome_autofill_client.cc
diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc
index 3134eaa88bdf26e94b46762033e30f1f45eac4c4..bab0ee79207962815db2b7b7edcc0c0b753e8707 100644
--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc
+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc
@@ -32,11 +32,13 @@
#include "chrome/common/url_constants.h"
#include "components/autofill/content/browser/content_autofill_driver.h"
#include "components/autofill/content/browser/content_autofill_driver_factory.h"
+#include "components/autofill/core/browser/popup_item_ids.h"
#include "components/autofill/core/browser/ui/card_unmask_prompt_view.h"
#include "components/autofill/core/common/autofill_pref_names.h"
#include "components/autofill/core/common/autofill_switches.h"
#include "components/browser_sync/profile_sync_service.h"
#include "components/password_manager/content/browser/content_password_manager_driver.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
#include "components/prefs/pref_service.h"
#include "components/signin/core/browser/profile_identity_provider.h"
#include "components/signin/core/browser/signin_header_helper.h"
@@ -372,14 +374,27 @@ bool ChromeAutofillClient::ShouldShowSigninPromo() {
#endif
}
-void ChromeAutofillClient::StartSigninFlow() {
+void ChromeAutofillClient::ExecuteCommand(int id) {
+ if (id == autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE) {
+ password_manager::metrics_util::LogShowedHttpNotSecureExplanation();
+ ShowHttpNotSecureExplanation();
+ } else if (id == autofill::POPUP_ITEM_ID_ALL_SAVED_PASSWORDS_ENTRY) {
+#if !defined(OS_ANDROID)
+ chrome::ShowSettingsSubPage(
+ chrome::FindBrowserWithWebContents(web_contents()),
+ chrome::kPasswordManagerSubPage);
+#endif
+ } else if (id == autofill::POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO) {
#if defined(OS_ANDROID)
- auto* window = web_contents()->GetNativeView()->GetWindowAndroid();
- if (window) {
- chrome::android::SigninPromoUtilAndroid::StartAccountSigninActivityForPromo(
- window, signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN);
- }
+ auto* window = web_contents()->GetNativeView()->GetWindowAndroid();
+ if (window) {
+ chrome::android::SigninPromoUtilAndroid::
+ StartAccountSigninActivityForPromo(
+ window,
+ signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN);
+ }
#endif
+ }
}
void ChromeAutofillClient::ShowHttpNotSecureExplanation() {
« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/browser/ui/views/autofill/autofill_popup_view_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698