Skeleton for showing "Show all saved passwords row" for Linux/CrOs/Windows platforms

chrome/browser/ui/autofill/chrome_autofill_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/ui/autofill/autofill_popup_controller_impl.h"
 #include "chrome/browser/ui/autofill/create_card_unmask_prompt_view.h"
 #include "chrome/browser/ui/autofill/credit_card_scanner_controller.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
 #include "chrome/browser/web_data_service_factory.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/content/browser/content_autofill_driver.h"
 #include "components/autofill/content/browser/content_autofill_driver_factory.h"
+#include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/ui/card_unmask_prompt_view.h"
 #include "components/autofill/core/common/autofill_pref_names.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/browser_sync/profile_sync_service.h"
 #include "components/password_manager/content/browser/content_password_manager_driver.h"
+#include "components/password_manager/core/browser/password_manager_metrics_util.h"
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/profile_identity_provider.h"
 #include "components/signin/core/browser/signin_header_helper.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/ssl_status.h"
 #include "ui/gfx/geometry/rect.h"
 
@@ skipping 319 matching lines @@
 
 bool ChromeAutofillClient::ShouldShowSigninPromo() {
 #if !defined(OS_ANDROID)
   return false;
 #else
   return signin::ShouldShowPromo(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
 #endif
 }
 
 void ChromeAutofillClient::StartSigninFlow() {

[Evan Stade, 2017/07/13 16:48:43]

I believe you can make this one use ExecuteCommand as well, with id ==
POPUP_ITEM_ID_CREDIT_CARD_SIGNIN_PROMO

[melandory, 2017/07/25 15:08:50]

Done.

 #if defined(OS_ANDROID)
   chrome::android::SigninPromoUtilAndroid::StartAccountSigninActivityForPromo(
       content::ContentViewCore::FromWebContents(web_contents()),
       signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN);
 #endif
 }
 
 void ChromeAutofillClient::ShowHttpNotSecureExplanation() {
 #if !defined(OS_ANDROID)
   // On desktop platforms, open Page Info, which briefly explains the HTTP
   // warning message and provides a link to the Help Center for more details.
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
   if (browser && chrome::ShowPageInfo(browser, web_contents()))
     return;
 // Otherwise fall through to the section below that opens the URL directly.
 #endif
 
   // On Android, where Page Info does not (yet) contain a link to the Help
   // Center (https://crbug.com/679532), or in corner cases where Page Info is
   // not shown (for example, no navigation entry), just launch the Help topic
   // directly.
   const GURL kSecurityIndicatorHelpCenterUrl(
       "https://support.google.com/chrome/?p=ui_security_indicator");
   web_contents()->OpenURL(content::OpenURLParams(
       GURL(kSecurityIndicatorHelpCenterUrl), content::Referrer(),
       WindowOpenDisposition::NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK,
       false /* is_renderer_initiated */));
 }
 
+bool ChromeAutofillClient::ExecuteCommand(int id) {

[Evan Stade, 2017/07/13 16:48:43]

nit: please keep function implementations in the same order as the declarations

[melandory, 2017/07/25 15:08:50]

Done.

+  if (id == autofill::POPUP_ITEM_ID_HTTP_NOT_SECURE_WARNING_MESSAGE) {
+    password_manager::metrics_util::LogShowedHttpNotSecureExplanation();
+    ShowHttpNotSecureExplanation();

[vasilii, 2017/07/13 16:11:51]

Should you drop ShowHttpNotSecureExplanation() from the interface and make it
non-virtual?

[Evan Stade, 2017/07/13 16:48:43]

yes please

[melandory, 2017/07/25 15:08:50]

Done.

+    return true;
+  } else if (id == autofill::POPUP_ITEM_ID_ALL_SAVED_PASSWORDS_ENTRY) {
+    ShowPasswordsSettingsPage();
+    return true;
+  }
+  return false;
+}
+
+void ChromeAutofillClient::ShowPasswordsSettingsPage() {

[Evan Stade, 2017/07/13 16:48:43]

doesn't seem worth adding this function since it's a one-liner

[melandory, 2017/07/25 15:08:50]

Done.

+#if !defined(OS_ANDROID)
+  chrome::ShowSettingsSubPage(
+      chrome::FindBrowserWithWebContents(web_contents()),
+      chrome::kPasswordManagerSubPage);
+#endif
+}
+
 }  // namespace autofill