Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2971713002: Use aggregated bindings for jumbo as well as for Windows. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
index 4d57a5e94a319b57824e57fe0e13348beea69e95..2ce65e6af226379d07cbfad9c94be08e4656f235 100644
--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
@@ -111,7 +111,7 @@ generated_core_callback_function_files = [
"$bindings_core_v8_output_dir/ResizeObserverCallback.h",
]
-if (is_win) {
+if (is_win || use_jumbo_build) {
# On Windows Official release builds, we try to preserve symbol space.
bindings_core_generated_interface_files =
[ "$bindings_core_v8_output_dir/V8GeneratedCoreBindings.cpp" ]
@@ -129,7 +129,7 @@ group("bindings_core_v8_generated") {
public_deps = [
":bindings_core_impl_generated",
]
- if (is_win) {
+ if (is_win || use_jumbo_build) {
public_deps += [ ":generate_bindings_core_v8_all_interfaces" ]
} else {
public_deps += [ ":generate_bindings_core_v8_interfaces" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698