Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2971693002: Split MemberTypeInformation by member kind (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix. #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -85 lines) Patch
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 7 chunks +155 lines, -79 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 3 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-04 12:16:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2971693002/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right): https://codereview.chromium.org/2971693002/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart#newcode572 pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:572: bool hasStableType(InferrerEngine inferrer) { delete this one (and ...
3 years, 5 months ago (2017-07-05 20:39:39 UTC) #3
Johnni Winther
https://codereview.chromium.org/2971693002/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart File pkg/compiler/lib/src/inferrer/type_graph_nodes.dart (right): https://codereview.chromium.org/2971693002/diff/20001/pkg/compiler/lib/src/inferrer/type_graph_nodes.dart#newcode572 pkg/compiler/lib/src/inferrer/type_graph_nodes.dart:572: bool hasStableType(InferrerEngine inferrer) { On 2017/07/05 20:39:39, Siggi Cherem ...
3 years, 5 months ago (2017-07-06 08:59:20 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-06 09:06:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
83082487bb8b2d2ffdf0ce0107acd1fb780514cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698