Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2971673002: Split ClassEnv into env and data to avoid copying types/constants from the k-model (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split ClassEnv into env and data to avoid copying types/constants from the k-model R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ba4220c563b521aad5a4ee45eae4eaa070036c88

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -85 lines) Patch
M pkg/compiler/lib/src/js_model/elements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 18 chunks +77 lines, -74 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 6 chunks +39 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/js_model/model_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-04 09:31:21 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1784 pkg/compiler/lib/src/kernel/element_map_impl.dart:1784: /*@override delete? https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/env.dart File pkg/compiler/lib/src/kernel/env.dart (right): https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/env.dart#newcode160 pkg/compiler/lib/src/kernel/env.dart:160: ...
3 years, 5 months ago (2017-07-05 20:19:01 UTC) #3
Johnni Winther
https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2971673002/diff/1/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1784 pkg/compiler/lib/src/kernel/element_map_impl.dart:1784: /*@override On 2017/07/05 20:19:01, Siggi Cherem (dart-lang) wrote: > ...
3 years, 5 months ago (2017-07-06 13:36:38 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-07-06 13:45:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ba4220c563b521aad5a4ee45eae4eaa070036c88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698