Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 297163014: DevTools: Some printed objects in console are not pinnable. (Closed)

Created:
6 years, 6 months ago by aandrey
Modified:
6 years, 6 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Some printed objects in console are not pinnable. For example: console.log(new Date) BUG=327109 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -21 lines) Patch
M Source/devtools/front_end/console/ConsoleViewMessage.js View 6 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
aandrey
6 years, 6 months ago (2014-05-28 13:48:03 UTC) #1
aandrey
FYI, this also handles console.log(Symbol())
6 years, 6 months ago (2014-05-28 13:55:21 UTC) #2
aandrey
6 years, 6 months ago (2014-05-30 10:00:12 UTC) #3
yurys
lgtm
6 years, 6 months ago (2014-05-30 11:43:21 UTC) #4
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 6 months ago (2014-05-30 12:11:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/297163014/1
6 years, 6 months ago (2014-05-30 12:12:17 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 14:11:18 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 15:09:12 UTC) #8
Message was sent while issue was closed.
Change committed as 175141

Powered by Google App Engine
This is Rietveld 408576698