Fixed the order of applying transform operations for animation bounds.

Fixed the order of applying transform operations for animation bounds.

When applying animations we squash the transforms and therefore
end up applying them in reverse order. When we have to calculate bounds
we end up applying them one at a time, so we also have to apply this
in reverse order.

Also modified how we calculate bounds for arcs to simplify the derivation.

R=ajuma@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273098

[ajuma, 2014-05-27 16:00:54]

lgtm with some style nits

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
File cc/animation/transform_operation.cc (right):

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operation.cc:334: // t = atan2(v2.x, v1.x) + n*M_PI;
Very nice!

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
File cc/animation/transform_operations_unittest.cc (right):

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1237: gfx::Transform
blendedTransform =
nit: blended_transform

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1239: gfx::Point3F
blendedPoint(0.9, 0.9, 0);
nit: blended_point

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1241: gfx::BoxF expandedBounds =
bounds;
expanded_bounds

[awoloszyn, 2014-05-27 16:08:09]

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
File cc/animation/transform_operations_unittest.cc (right):

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1237: gfx::Transform
blendedTransform =
On 2014/05/27 16:00:54, ajuma wrote:
> nit: blended_transform

Thanks! Turns out my brain was still at least partially trying to use blink
style.

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1239: gfx::Point3F
blendedPoint(0.9, 0.9, 0);
On 2014/05/27 16:00:54, ajuma wrote:
> nit: blended_point

Done.

https://codereview.chromium.org/297163010/diff/1/cc/animation/transform_opera...
cc/animation/transform_operations_unittest.cc:1241: gfx::BoxF expandedBounds =
bounds;
On 2014/05/27 16:00:54, ajuma wrote:
> expanded_bounds

Done.

[awoloszyn, 2014-05-27 17:11:19]

The CQ bit was checked by awoloszyn@chromium.org

[commit-bot: I haz the power, 2014-05-27 17:12:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/awoloszyn@chromium.org/297163010/20001

[awoloszyn, 2014-05-27 18:44:21]

Windows build bots were complaining (rightly so) about a double-float conversion
that should not have been there.

[awoloszyn, 2014-05-27 19:39:21]

The CQ bit was checked by awoloszyn@chromium.org

[commit-bot: I haz the power, 2014-05-27 19:40:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/awoloszyn@chromium.org/297163010/40001

[commit-bot: I haz the power, 2014-05-27 23:41:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-28 01:18:58]

Change committed as 273098