Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 297163009: Revert "Make 'name' property on functions configurable." (Closed)

Created:
6 years, 7 months ago by Michael Starzinger
Modified:
6 years, 7 months ago
Reviewers:
danno-g, danno
CC:
v8-dev
Visibility:
Public.

Description

Revert "Make 'name' property on functions configurable." R=danno@google.com, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M src/bootstrapper.cc View 3 chunks +15 lines, -19 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1530.js View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-270142.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
This reverts a perfectly fine conformance fix because the test expectation didn't make it into ...
6 years, 7 months ago (2014-05-27 14:57:52 UTC) #1
danno-g
rubber-stamp lgtm
6 years, 7 months ago (2014-05-27 14:58:50 UTC) #2
Michael Starzinger
6 years, 7 months ago (2014-05-27 15:00:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21534 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698