Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 297163008: Added initialization of SessionManagerOperation::slot_. (Closed)

Created:
6 years, 7 months ago by ygorshenin1
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Added initialization of SessionManagerOperation::slot_. BUG=377078 TEST=manual R=mnissler@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272943

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ygorshenin1
6 years, 7 months ago (2014-05-27 08:42:31 UTC) #1
Mattias Nissler (ping if slow)
LGTM
6 years, 7 months ago (2014-05-27 08:48:26 UTC) #2
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-05-27 08:49:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/297163008/1
6 years, 7 months ago (2014-05-27 08:49:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 10:43:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 11:08:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77839)
6 years, 7 months ago (2014-05-27 11:08:07 UTC) #7
ygorshenin1
6 years, 7 months ago (2014-05-27 11:13:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r272943 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698