Issue 297163007: Removed webkit prefix when creating peerconnection object + fix DTMF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297163007: Removed webkit prefix when creating peerconnection object + fix DTMF (Closed)

Created:
6 years, 7 months ago by jansson

Modified:
6 years, 7 months ago

Reviewers:
kjellander_chromium

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Removed webkit prefix when creating peerconnection object which means it will use adapter.js instead. Discovered that DTMF was broken and it was a simple fix by just removing a erronous function call, it's a variable... NOTE: This is a WebRTC in Chrome manual test page. BUG=377653 TEST=Setup a P2P call, add, remove and stop streams, SCTP&RTP datachannels, and send DTMF NOTRY=TRUE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272940

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/test/data/webrtc/manual/peerconnection.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jansson@chromium.org/297163007/1

6 years, 7 months ago (2014-05-27 09:55:13 UTC) #4

Message was sent while issue was closed.

Change committed as 272940

Expand Messages | Collapse Messages