Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: trunk/src/components/dom_distiller/core/distiller_page.h

Issue 297163003: Revert 272611 "Add support for distilling current WebContents" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/dom_distiller/core/distiller_page.h
===================================================================
--- trunk/src/components/dom_distiller/core/distiller_page.h (revision 272703)
+++ trunk/src/components/dom_distiller/core/distiller_page.h (working copy)
@@ -29,11 +29,6 @@
DISALLOW_COPY_AND_ASSIGN(DistilledPageInfo);
};
-class SourcePageHandle {
- public:
- virtual ~SourcePageHandle() {}
-};
-
// Injects JavaScript into a page, and uses it to extract and return long-form
// content. The class can be reused to load and distill multiple pages,
// following the state transitions described along with the class's states.
@@ -67,6 +62,10 @@
// should be the same regardless of the DistillerPage implementation.
virtual void DistillPageImpl(const GURL& url, const std::string& script) = 0;
+ // Called by |ExecuteJavaScript| to carry out platform-specific instructions
+ // to inject and execute JavaScript within the context of the loaded page.
+ //virtual void ExecuteJavaScriptImpl() = 0;
+
private:
bool ready_;
DistillerPageCallback distiller_page_callback_;
@@ -82,8 +81,6 @@
// should be very cheap, since the pages can be thrown away without being
// used.
virtual scoped_ptr<DistillerPage> CreateDistillerPage() const = 0;
- virtual scoped_ptr<DistillerPage> CreateDistillerPageWithHandle(
- scoped_ptr<SourcePageHandle> handle) const = 0;
};
} // namespace dom_distiller

Powered by Google App Engine
This is Rietveld 408576698