Issue 297163003: Revert 272611 "Add support for distilling current WebContents"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297163003: Revert 272611 "Add support for distilling current WebContents" (Closed)

Created:
6 years, 7 months ago by sadrul

Modified:
6 years, 7 months ago

Reviewers:
nyquist

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 272611 "Add support for distilling current WebContents" The test added in this CL DomDistillerTabUtilsBrowserTest.TestSwapWebContents consistently fails on some bots, e.g. http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%284%29/builds/41414 http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/27225 http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29/builds/48492 > Add support for distilling current WebContents > > This CL adds the utilities needed for using the current WebContents when > distilling web pages. > > BUG=361939 > > Review URL: https://codereview.chromium.org/266073003 TBR=nyquist@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272704

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -810 lines)			Patch
D	trunk/src/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	trunk/src/chrome/browser/android/chrome_jni_registrar.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/dom_distiller/lazy_dom_distiller_service.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/dom_distiller/lazy_dom_distiller_service.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	trunk/src/chrome/browser/dom_distiller/tab_utils.h	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	trunk/src/chrome/browser/dom_distiller/tab_utils.cc	View	1 chunk	+0 lines, -160 lines	0 comments	Download
D	trunk/src/chrome/browser/dom_distiller/tab_utils_android.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	trunk/src/chrome/browser/dom_distiller/tab_utils_android.cc	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/src/chrome/browser/dom_distiller/tab_utils_browsertest.cc	View	1 chunk	+0 lines, -91 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/tab_helpers.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	trunk/src/chrome/test/data/dom_distiller/simple_article.html	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	trunk/src/components/dom_distiller.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/components/dom_distiller/content/distiller_page_web_contents.h	View	5 chunks	+2 lines, -23 lines	0 comments	Download
M	trunk/src/components/dom_distiller/content/distiller_page_web_contents.cc	View	5 chunks	+7 lines, -64 lines	0 comments	Download
M	trunk/src/components/dom_distiller/content/distiller_page_web_contents_browsertest.cc	View	7 chunks	+7 lines, -194 lines	0 comments	Download
D	trunk/src/components/dom_distiller/content/web_contents_main_frame_observer.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	trunk/src/components/dom_distiller/content/web_contents_main_frame_observer.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	trunk/src/components/dom_distiller/core/distiller_page.h	View	3 chunks	+4 lines, -7 lines	0 comments	Download
M	trunk/src/components/dom_distiller/core/dom_distiller_service.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/components/dom_distiller/core/dom_distiller_service.cc	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	trunk/src/components/dom_distiller/core/fake_distiller_page.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/components/dom_distiller/core/viewer_unittest.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 7 months ago (2014-05-24 05:42:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r272704 (tree was closed).

Expand Messages | Collapse Messages