Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/analysis_server/test/analysis_server_test.dart

Issue 297153002: Implementation of 'Server Domain' in dart analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis_server_test.dart
diff --git a/pkg/analysis_server/test/analysis_server_test.dart b/pkg/analysis_server/test/analysis_server_test.dart
index a4b3fc34ef7114b9a584ef5e2eedc9fad643b38e..d730201bdf6a7420cdabc59319877ef79ac76212 100644
--- a/pkg/analysis_server/test/analysis_server_test.dart
+++ b/pkg/analysis_server/test/analysis_server_test.dart
@@ -26,7 +26,8 @@ main() {
AnalysisServerTest.addContextToWorkQueue_whenNotRunning);
test('addContextToWorkQueue_whenRunning',
AnalysisServerTest.addContextToWorkQueue_whenRunning);
- test('createContext', AnalysisServerTest.createContext);
+ // TODO(scheglov) remove or move to the 'analysis' domain
+// test('createContext', AnalysisServerTest.createContext);
test('echo', AnalysisServerTest.echo);
test('errorToJson_formattingApplied',
AnalysisServerTest.errorToJson_formattingApplied);
@@ -102,17 +103,18 @@ class AnalysisServerTest {
context.getLogs(callsTo('performAnalysisTask')).verify(happenedExactly(1)));
}
- static Future createContext() {
- server.handlers = [new ServerDomainHandler(server)];
- var request = new Request('my27', ServerDomainHandler.CREATE_CONTEXT_METHOD);
- request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
- request.setParameter(AnalysisServer.CONTEXT_ID_PARAM, 'ctx');
- return channel.sendRequest(request)
- .then((Response response) {
- expect(response.id, equals('my27'));
- expect(response.error, isNull);
- });
- }
+ // TODO(scheglov) remove or move to the 'analysis' domain
+// static Future createContext() {
+// server.handlers = [new ServerDomainHandler(server)];
+// var request = new Request('my27', ServerDomainHandler.CREATE_CONTEXT_METHOD);
+// request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, sdkPath);
+// request.setParameter(AnalysisServer.CONTEXT_ID_PARAM, 'ctx');
+// return channel.sendRequest(request)
+// .then((Response response) {
+// expect(response.id, equals('my27'));
+// expect(response.error, isNull);
+// });
+// }
static Future echo() {
server.handlers = [new EchoHandler()];
@@ -182,7 +184,6 @@ class AnalysisServerTest {
static Future shutdown() {
server.handlers = [new ServerDomainHandler(server)];
var request = new Request('my28', ServerDomainHandler.SHUTDOWN_METHOD);
- request.setParameter(ServerDomainHandler.SDK_DIRECTORY_PARAM, '');
return channel.sendRequest(request)
.then((Response response) {
expect(response.id, equals('my28'));

Powered by Google App Engine
This is Rietveld 408576698