Issue 2971453002: Avoid string interpolation in templates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2971453002: Avoid string interpolation in templates. (Closed)

Created:
3 years, 5 months ago by Leaf

Modified:
3 years, 4 months ago

Reviewers:
sra1

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid string interpolation in templates. Replace some constant string interpolation with literal strings. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/61e071e3e7a904b55c7e816a6496fdf4a81be799

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View		3 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Leaf

3 years, 4 months ago (2017-07-27 20:47:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
61e071e3e7a904b55c7e816a6496fdf4a81be799 (presubmit successful).