Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2971443002: Output errors for tests that fail to compile (Closed)

Created:
3 years, 5 months ago by vsm
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Output errors for tests that fail to compile This makes it easier to fix strong mode errors in tests. R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/9cbd5bdc2e0b0f4117b3168c8c4c4d9870090523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M pkg/dev_compiler/test/codegen_test.dart View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 5 months ago (2017-06-30 23:26:08 UTC) #3
Bob Nystrom
lgtm
3 years, 5 months ago (2017-07-05 16:23:40 UTC) #4
vsm
3 years, 5 months ago (2017-07-05 16:37:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9cbd5bdc2e0b0f4117b3168c8c4c4d9870090523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698