Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 297143009: MacViews: Gets views_examples_with_content_exe compiling on Mac (Closed)

Created:
6 years, 6 months ago by tapted
Modified:
6 years, 6 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, sadrul, tfarina, darin-cc_chromium.org, ben+ash_chromium.org, kalyank, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Visibility:
Public.

Description

MacViews: Gets views_examples_with_content_exe compiling on Mac This splits views_content_client_main_parts_* into versions for ChromeOS, Mac and Desktop Aura, with a per-platform Create(..) function. ChromeOS and Desktop Aura sharing a common Aura part. desktop_test_views_delegate.cc is moved to an _aura version, and a _mac version added. views_content_client now loads content_resources.pak to access sandbox profiles required for mac. A macviews_builder target is added to expose views_examples_with_content_exe on Mac, and to give the fyi trybot something to build. BUG=366007 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274775

Patch Set 1 #

Patch Set 2 : failed ui::EventFromNative attempt #

Patch Set 3 : RepostNativeEvent #

Patch Set 4 : rebase on crrev/303473010 #

Patch Set 5 : rebase on crrev/307623002 #

Patch Set 6 : rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+340 lines, -116 lines) Patch
M build/all.gyp View 1 2 3 4 5 1 chunk +14 lines, -1 line 0 comments Download
M content/shell/browser/shell_mac.mm View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/views/examples/examples.gyp View 4 chunks +12 lines, -2 lines 0 comments Download
M ui/views/examples/examples_window.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/examples/examples_window.cc View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/test/desktop_test_views_delegate.cc View 1 chunk +0 lines, -36 lines 0 comments Download
A + ui/views/test/desktop_test_views_delegate_aura.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/views/test/desktop_test_views_delegate_mac.mm View 1 2 chunks +6 lines, -10 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_browser_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views_content_client/views_content_client.gyp View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_client_main_parts.h View 2 chunks +12 lines, -14 lines 0 comments Download
M ui/views_content_client/views_content_client_main_parts.cc View 2 chunks +0 lines, -49 lines 0 comments Download
A ui/views_content_client/views_content_client_main_parts_aura.h View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
A ui/views_content_client/views_content_client_main_parts_aura.cc View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
A ui/views_content_client/views_content_client_main_parts_chromeos.cc View 1 2 3 4 5 1 chunk +75 lines, -0 lines 0 comments Download
A ui/views_content_client/views_content_client_main_parts_desktop_aura.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
A ui/views_content_client/views_content_client_main_parts_mac.mm View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download
M ui/views_content_client/views_content_main_delegate.cc View 1 2 3 4 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tapted
Hi sky, please take a look. Note: during a spot-check on a ChromeOS build, I ...
6 years, 6 months ago (2014-06-03 08:09:04 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-03 16:08:31 UTC) #2
tapted
+jam for OWNERS for content/shell/browser/shell_mac.mm (just adding stub to match the header for now so ...
6 years, 6 months ago (2014-06-03 23:07:49 UTC) #3
jam
On 2014/06/03 23:07:49, tapted wrote: > +jam for OWNERS for content/shell/browser/shell_mac.mm (just adding stub to ...
6 years, 6 months ago (2014-06-04 00:24:38 UTC) #4
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 6 months ago (2014-06-04 00:32:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/297143009/310001
6 years, 6 months ago (2014-06-04 00:35:21 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 02:01:11 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 11:29:09 UTC) #8
Message was sent while issue was closed.
Change committed as 274775

Powered by Google App Engine
This is Rietveld 408576698