[Win] UI fixes for the new avatar button/bubble auth errors.

chrome/browser/ui/views/frame/glass_browser_frame_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/glass_browser_frame_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/app/chrome_dll_resource.h"
@@ skipping 428 matching lines @@
        kClientEdgeThickness,
        client_area_bottom + kClientEdgeThickness - client_area_top),
        toolbar_color);
 }
 
 void GlassBrowserFrameView::LayoutNewStyleAvatar() {
   DCHECK(switches::IsNewAvatarMenu());
   if (!new_avatar_button())
     return;
 
+  // We need to offset the button correctly in maximized mode, so that the
+  // custom glass style aligns with the native control glass style. Determined
+  // by visual inspection.
+  const int maximized_frame_offset = 7;

[msw, 2014/06/09 21:42:40]

This should probably be determined by some NonClientFrameView value like
FrameBorderThickness/NonClientBorderThickness/NonClientTopBorderHeight, as it
might vary by system DPI, Vista/7, etc. Can you try that approach again (ditto
below), without expending too much effort? Maybe ping ben/sky for ideas?

[noms (inactive), 2014/06/18 18:07:24]

Done! I've cleaned up the code a bit too. There's still 1px hard coded, but
everything else around it is better. (I hope).

On 2014/06/09 21:42:40, msw wrote:

   gfx::Size label_size = new_avatar_button()->GetPreferredSize();
   int button_size_with_offset = kNewAvatarButtonOffset + label_size.width();
 
   int button_x = frame()->GetMinimizeButtonOffset() -
       kNewAvatarButtonOffset - label_size.width();
   if (base::i18n::IsRTL())
     button_x = width() - frame()->GetMinimizeButtonOffset() +
         kNewAvatarButtonOffset;
-  int button_y = frame()->IsMaximized() ? NonClientTopBorderHeight() : 1;
+  int button_y = frame()->IsMaximized() ? maximized_frame_offset : 1;
 
-  // If the window is maximized, the button is 2 pixels too tall. Determined
-  // via visual inspection.
-  int height_to_subtract = frame()->IsMaximized() ? 2 : 0;
+  // If the window is maximized, we need to subtract the previously added
+  // offset, plus an extra pixel which makes the button too tall. The latter
+  // was determined by visual inspection.
+  int height_to_subtract =
+      frame()->IsMaximized() ? maximized_frame_offset - 1 : 0;
 
   new_avatar_button()->SetBounds(
       button_x,
       button_y,
       label_size.width(),
       button_y + gfx::win::GetSystemMetricsInDIP(SM_CXMENUSIZE) -
           height_to_subtract);
 }
 
 void GlassBrowserFrameView::LayoutAvatar() {
@@ skipping 115 matching lines @@
   static bool initialized = false;
   if (!initialized) {
     for (int i = 0; i < kThrobberIconCount; ++i) {
       throbber_icons_[i] =
           ui::LoadThemeIconFromResourcesDataDLL(IDI_THROBBER_01 + i);
       DCHECK(throbber_icons_[i]);
     }
     initialized = true;
   }
 }