Detect if osk is visible on windows

ui/base/win/osk_display_manager.cc

Index: ui/base/win/osk_display_manager.cc
diff --git a/ui/base/win/osk_display_manager.cc b/ui/base/win/osk_display_manager.cc
index 0373b48bdd39f79b4f04d4ea45d1326c68a7e48f..49b7179a52668ad4a20bc5774ed140233e0a4371 100644
--- a/ui/base/win/osk_display_manager.cc
+++ b/ui/base/win/osk_display_manager.cc
@@ -360,4 +360,11 @@ bool OnScreenKeyboardDisplayManager::GetOSKPath(base::string16* osk_path) {
   return !osk_path->empty();
 }
 
+bool OnScreenKeyboardDisplayManager::IsKeyboardVisible() {

[Peter Kasting, 2017/07/08 02:19:31]

This file already has CheckIfKeyboardVisible() above, which looks like a
stricter version of this check.  Having both these is confusing.  Can we unify? 
If not, can we make it really clear why these need to differ?

(I found this because I was checking to see whether other functions could
replace calls to e.g. IsWindowEnabled() with calls to this function, to which my
answer is "maybe".)

[girard, 2017/07/10 20:23:51]

Patchset 2 contains this fix. The refactor was a bit strange because of the
function's side-effects, but I think the new code is cleaner.

+  if (base::win::GetVersion() < base::win::VERSION_WIN8)
+    return false;
+  HWND osk = ::FindWindow(kOSKClassName, nullptr);
+  return !!::IsWindow(osk) && !!::IsWindowEnabled(osk);
+}
+
 }  // namespace ui