 Chromium Code Reviews
 Chromium Code Reviews Issue 2971363002:
  Detect if osk is visible on windows  (Closed)
    
  
    Issue 2971363002:
  Detect if osk is visible on windows  (Closed) 
  | Index: chrome/browser/ui/views/location_bar/location_bar_view.cc | 
| diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc | 
| index a962a9e1518d1226bc0f1cfada820fa748c3ae11..f59c2a4e5f79b5ebb76b99c6825a0fffc2e16728 100644 | 
| --- a/chrome/browser/ui/views/location_bar/location_bar_view.cc | 
| +++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc | 
| @@ -103,6 +103,10 @@ | 
| #include "ui/keyboard/keyboard_util.h" | 
| #endif | 
| +#if defined(OS_WIN) | 
| +#include "ui/base/win/osk_display_manager.h" | 
| +#endif | 
| + | 
| using content::WebContents; | 
| using views::View; | 
| @@ -741,7 +745,9 @@ void LocationBarView::ButtonPressed(views::Button* sender, | 
| } | 
| bool LocationBarView::IsVirtualKeyboardVisible() { | 
| -#if defined(USE_AURA) | 
| +#if defined(OS_WIN) | 
| + return ui::OnScreenKeyboardDisplayManager::GetInstance()->IsKeyboardVisible(); | 
| 
Peter Kasting
2017/07/08 02:19:31
Should we just make Aura's keyboard::IsKeyboardVis
 
girard
2017/07/10 20:23:51
I thought about this, but I'm worried about all th
 
Peter Kasting
2017/07/10 21:10:12
I'm not knowledgeable about that space.  Can you c
 | 
| +#elif defined(USE_AURA) | 
| return keyboard::IsKeyboardVisible(); | 
| #else | 
| return false; |