Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2625)

Unified Diff: chrome/browser/ui/webui/settings/people_handler.h

Issue 2971353002: [sync] Prevent flash of error icon while loading syncSetup page (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/people_handler.h
diff --git a/chrome/browser/ui/webui/settings/people_handler.h b/chrome/browser/ui/webui/settings/people_handler.h
index 7b587f71633eb0597223b66936e8f18f8f80e7ed..2f73c1b4901663eac98a2992f597c4d2a3f1404a 100644
--- a/chrome/browser/ui/webui/settings/people_handler.h
+++ b/chrome/browser/ui/webui/settings/people_handler.h
@@ -98,6 +98,8 @@ class PeopleHandler : public SettingsPageUIHandler,
FRIEND_TEST_ALL_PREFIXES(PeopleHandlerNonCrosTest,
SubmitAuthWithInvalidUsername);
FRIEND_TEST_ALL_PREFIXES(PeopleHandlerFirstSigninTest, DisplayBasicLogin);
+ FRIEND_TEST_ALL_PREFIXES(PeopleHandlerTest,
+ AcquireSyncBlockerWhenLoadingSyncSettingsSubpage);
// SettingsPageUIHandler implementation.
void RegisterMessages() override;
@@ -174,6 +176,9 @@ class PeopleHandler : public SettingsPageUIHandler,
// Suppresses any further signin promos, since the user has signed in once.
void MarkFirstSetupComplete();
+ // Maybe acquire a SyncSetupInProgressHandle and store it in sync_blocker_.
+ void MaybeAcquireSyncBlocker();
+
// Weak pointer.
Profile* profile_;
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/people_handler.cc » ('j') | chrome/browser/ui/webui/settings/people_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698