Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2971343002: Fix strong_mode_test after moving driver_test fields into class. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix strong_mode_test after moving driver_test fields into class. TBR R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/671bedc8f630f68447e363e930db02a5a7718dbc

Patch Set 1 #

Patch Set 2 : Rollback unrelated change in elements. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -101 lines) Patch
M pkg/analyzer_cli/test/driver_test.dart View 9 chunks +65 lines, -65 lines 0 comments Download
M pkg/analyzer_cli/test/strong_mode_test.dart View 2 chunks +18 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-07 16:55:32 UTC) #1
scheglov
Committed patchset #2 (id:20001) manually as 671bedc8f630f68447e363e930db02a5a7718dbc (presubmit successful).
3 years, 5 months ago (2017-07-07 17:01:53 UTC) #3
Brian Wilkerson
3 years, 5 months ago (2017-07-19 16:14:56 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698