Switch cookie async mechanism over to using callbacks.

net/cookies/cookie_monster_perftest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 80 matching lines @@
 
  private:
   void Run(const std::string& cookies) {
     cookies_ = cookies;
     BaseCallback::Run();
   }
   std::string cookies_;
   CookieOptions options_;
 };
 
+class GetAllCookiesCallback : public BaseCallback {

[mmenke, 2017/07/12 18:29:04]

While you're here...would you mind renaming BaseCallback?  Given that
base::Callback is a thing, I was confused for a second there. 
MaybeWaitForResponseCallback?  Or just CookieTestCallback?

[Randy Smith (Not in Mondays), 2017/07/12 19:47:35]

Done.

+ public:
+  CookieList GetAllCookies(CookieMonster* cm) {
+    cm->GetAllCookiesAsync(
+        base::Bind(&GetAllCookiesCallback::Run, base::Unretained(this)));
+    WaitForCallback();
+    return cookies_;
+  }
+
+ private:
+  void Run(const CookieList& cookies) {
+    cookies_ = cookies;
+    BaseCallback::Run();
+  }
+  CookieList cookies_;
+};
+
 }  // namespace
 
 TEST(ParsedCookieTest, TestParseCookies) {
   std::string cookie(kCookieLine);
   base::PerfTimeLogger timer("Parsed_cookie_parse_cookies");
   for (int i = 0; i < kNumCookies; ++i) {
     ParsedCookie pc(cookie);
     EXPECT_TRUE(pc.IsValid());
   }
   timer.Done();
@@ skipping 109 matching lines @@
   }
 
   EXPECT_EQ(31u, domain_list.size());
   for (std::vector<std::string>::const_iterator it = domain_list.begin();
        it != domain_list.end(); it++) {
     GURL gurl("https://" + *it + "/");
     const std::string cookie =
         base::StringPrintf(domain_cookie_format_tree, it->c_str());
     setCookieCallback.SetCookie(cm.get(), gurl, cookie);
   }
-  EXPECT_EQ(31u, cm->GetAllCookies().size());
+
+  GetAllCookiesCallback getAllCookiesCallback;
+  EXPECT_EQ(31u, getAllCookiesCallback.GetAllCookies(cm.get()).size());
 
   GURL probe_gurl("https://b.a.b.a.top.com/");
   std::string cookie_line = getCookiesCallback.GetCookies(cm.get(), probe_gurl);
   EXPECT_EQ(5, CountInString(cookie_line, '='))
       << "Cookie line: " << cookie_line;
   base::PerfTimeLogger timer("Cookie_monster_query_domain_tree");
   for (int i = 0; i < kNumCookies; i++) {
     getCookiesCallback.GetCookies(cm.get(), probe_gurl);
   }
   timer.Done();
@@ skipping 141 matching lines @@
     setCookieCallback.SetCookie(cm.get(), gurl, cookie_line);
 
     base::PerfTimeLogger timer((std::string("GC_") + test_case.name).c_str());
     for (int i = 0; i < kNumCookies; i++)
       setCookieCallback.SetCookie(cm.get(), gurl, cookie_line);
     timer.Done();
   }
 }
 
 }  // namespace net