Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2971293002: Fix closure conversion in field and local initializers. (Closed)

Created:
3 years, 5 months ago by sjindel
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, Kasper Lund
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix closure conversion in field and local initializers. R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/a49dcb6bb15e390731685869305d7e7eca5df7a8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -17 lines) Patch
M pkg/kernel/lib/transformations/closure/rewriter.dart View 2 chunks +7 lines, -10 lines 0 comments Download
M pkg/kernel/test/closures_initializers/closures_initializers.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures_initializers/local_initializers.dart View 1 chunk +13 lines, -2 lines 1 comment Download
M pkg/kernel/testcases/closures_initializers/local_initializers.dart.expect View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sjindel
Karl: PTAL also
3 years, 5 months ago (2017-07-07 09:34:47 UTC) #4
Dmitry Stefantsov
Nice! LGTM with a small comment. https://codereview.chromium.org/2971293002/diff/1/pkg/kernel/testcases/closures_initializers/local_initializers.dart File pkg/kernel/testcases/closures_initializers/local_initializers.dart (right): https://codereview.chromium.org/2971293002/diff/1/pkg/kernel/testcases/closures_initializers/local_initializers.dart#newcode14 pkg/kernel/testcases/closures_initializers/local_initializers.dart:14: // Closure in ...
3 years, 5 months ago (2017-07-07 09:47:47 UTC) #5
sjindel
3 years, 5 months ago (2017-07-07 15:48:44 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a49dcb6bb15e390731685869305d7e7eca5df7a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698