Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2971253002: Remove visitLabelElement() and visitLocalVariableElement(). (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove visitLabelElement() and visitLocalVariableElement(). These elements are not parts of the bigger element model, so it does not make sense to implement these visit methods. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/2c064df1451568d4b1187b9a54d0ad7cc383612e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/dart/element/visitor.dart View 5 chunks +0 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +2 lines, -3 lines 2 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-06 22:01:23 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2971253002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2971253002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode5564 pkg/analyzer/lib/src/dart/element/element.dart:5564: T accept<T>(ElementVisitor<T> visitor) => null; It would be ...
3 years, 5 months ago (2017-07-06 22:42:52 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 2c064df1451568d4b1187b9a54d0ad7cc383612e (presubmit successful).
3 years, 5 months ago (2017-07-07 15:05:01 UTC) #4
scheglov
3 years, 5 months ago (2017-07-07 15:05:33 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/2971253002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/2971253002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:5564: T
accept<T>(ElementVisitor<T> visitor) => null;
On 2017/07/06 22:42:52, Brian Wilkerson wrote:
> It would be better to throw a not-implemented exception, just to make it
> explicit that the visitor won't be called.

Done.

Powered by Google App Engine
This is Rietveld 408576698