Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: pkg/dev_compiler/test/browser/language_tests.js

Issue 2971243003: fix #30094, assert should work with a function (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'], 5 define(['dart_sdk', 'async_helper', 'expect', 'unittest', 'is', 'require'],
6 function(dart_sdk, async_helper, expect, unittest, is, require) { 6 function(dart_sdk, async_helper, expect, unittest, is, require) {
7 'use strict'; 7 'use strict';
8 8
9 async_helper = async_helper.async_helper; 9 async_helper = async_helper.async_helper;
10 let minitest = expect.minitest; 10 let minitest = expect.minitest;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 const async_unittest = ['unittest', 'skip', 'fail']; 52 const async_unittest = ['unittest', 'skip', 'fail'];
53 53
54 // The number of expected unittest errors should be zero but unfortunately 54 // The number of expected unittest errors should be zero but unfortunately
55 // there are a lot of broken html unittests. 55 // there are a lot of broken html unittests.
56 let num_expected_unittest_fails = 4; 56 let num_expected_unittest_fails = 4;
57 let num_expected_unittest_errors = 0; 57 let num_expected_unittest_errors = 0;
58 58
59 // TODO(jmesserly): separate StrongModeError from other errors. 59 // TODO(jmesserly): separate StrongModeError from other errors.
60 let all_status = { 60 let all_status = {
61 'language': { 61 'language': {
62 'assertion_test': fail,
63 'async_await_test_none_multi': 'unittest', 62 'async_await_test_none_multi': 'unittest',
64 'async_await_test_02_multi': 'unittest', 63 'async_await_test_02_multi': 'unittest',
65 64
66 // Flaky on travis (https://github.com/dart-lang/sdk/issues/27224) 65 // Flaky on travis (https://github.com/dart-lang/sdk/issues/27224)
67 'async_await_test_03_multi': async_unittest, 66 'async_await_test_03_multi': async_unittest,
68 67
69 'async_star_await_pauses_test': skip_timeout, 68 'async_star_await_pauses_test': skip_timeout,
70 69
71 // TODO(jmesserly): figure out why this test is hanging. 70 // TODO(jmesserly): figure out why this test is hanging.
72 'async_star_cancel_and_throw_in_finally_test': skip_timeout, 71 'async_star_cancel_and_throw_in_finally_test': skip_timeout,
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 903
905 for (let action of unittest_tests) { 904 for (let action of unittest_tests) {
906 try { 905 try {
907 action(); 906 action();
908 } catch (e) { 907 } catch (e) {
909 console.error("Caught error tying to setup test:", e); 908 console.error("Caught error tying to setup test:", e);
910 } 909 }
911 } 910 }
912 }); 911 });
913 }); 912 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698