extensions/browser/app_window/native_app_window.h - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/native_app_window.h

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WidgetObserver instead of plumbing SetKeyboardIntercept through view::Widget Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/app_window/app_window.cc ('K') | « extensions/browser/app_window/app_window.cc ('k') | extensions/browser/extension_function_histogram_value.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/native_app_window.h

diff --git a/extensions/browser/app_window/native_app_window.h b/extensions/browser/app_window/native_app_window.h

index 2c37fe0e801ddd647d5f7a6cc21a58addf360532..bb7e467e6b96a5f5119fc05532ad70545840c2a0 100644

--- a/extensions/browser/app_window/native_app_window.h

+++ b/extensions/browser/app_window/native_app_window.h

@@ -54,6 +54,10 @@ class NativeAppWindow : public ui::BaseWindow,

// window is restored to the default shape.

virtual void UpdateShape(scoped_ptr<SkRegion> region) = 0;

+ // Set whether the window should receive all keyboard events including task

+ // switching keys.

+ virtual void SetInterceptAllKeys(bool want_all_keys) = 0;

// Allows the window to handle unhandled keyboard messages coming back from

// the renderer.

virtual void HandleKeyboardEvent(