chrome/chrome_browser_ui.gypi - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WidgetObserver instead of plumbing SetKeyboardIntercept through view::Widget Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc ('K') | « chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc ('k') | chrome/chrome_tests.gypi » ('j') | extensions/browser/app_window/app_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 280fdf5f3193269ef8b7daa0d101198dd7cec17a..ec81fbba1ce39357b13a450f07b5cec9dd5c5070 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -1873,8 +1873,12 @@

'browser/ui/views/apps/chrome_native_app_window_views.h',

'browser/ui/views/apps/chrome_native_app_window_views_win.cc',

'browser/ui/views/apps/chrome_native_app_window_views_win.h',

+ 'browser/ui/views/apps/desktop_keyboard_capture.cc',

+ 'browser/ui/views/apps/desktop_keyboard_capture.h',

'browser/ui/views/apps/glass_app_window_frame_view_win.cc',

'browser/ui/views/apps/glass_app_window_frame_view_win.h',

+ 'browser/ui/views/apps/keyboard_hook_handler.h',

+ 'browser/ui/views/apps/keyboard_hook_handler_win.cc',

'browser/ui/views/apps/shaped_app_window_targeter.cc',

'browser/ui/views/apps/shaped_app_window_targeter.h',

'browser/ui/views/ash/tab_scrubber.cc',

@@ -2501,6 +2505,7 @@

'chrome_browser_ui_linux_sources': [

'browser/ui/startup/autolaunch_prompt.cc',

'browser/ui/views/apps/chrome_apps_client_views.cc',

+ 'browser/ui/views/apps/keyboard_hook_handler.cc',

benwells 2014/11/21 00:52:01 mac?

Sriram 2014/11/21 20:39:45 Missed replying to this one - Native app window fo

'browser/ui/views/frame/taskbar_decorator.cc',

'browser/ui/webui/certificate_viewer_ui.cc',

'browser/ui/webui/certificate_viewer_ui.h',