ui/views/widget/desktop_aura/desktop_native_widget_aura.h - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated based on Ben's CR comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/views/widget/desktop_aura/desktop_keyboard_capture_win.cc ('K') | « ui/views/widget/desktop_aura/desktop_keyboard_capture_win.cc ('k') | ui/views/widget/desktop_aura/desktop_native_widget_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.h

diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.h b/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

index c26ff96015ef923e8f93d3fda1f5c94ef63a4050..a6cc308266309ae1f7db898bc3f591777f046c8f 100644

--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

@@ -150,6 +150,7 @@ class VIEWS_EXPORT DesktopNativeWidgetAura

virtual void SetAlwaysOnTop(bool always_on_top) OVERRIDE;

virtual bool IsAlwaysOnTop() const OVERRIDE;

virtual void SetVisibleOnAllWorkspaces(bool always_visible) OVERRIDE;

+ virtual void SetInterceptAllKeys(bool want_all_keys) OVERRIDE;

virtual void Maximize() OVERRIDE;

virtual void Minimize() OVERRIDE;

virtual bool IsMaximized() const OVERRIDE;

@@ -295,6 +296,9 @@ class VIEWS_EXPORT DesktopNativeWidgetAura

bool restore_focus_on_activate_;

bool restore_focus_on_window_focus_;

+ // Should all keys be intercepted while the window is in focus.

+ bool intercept_all_keys_on_focus_;

gfx::NativeCursor cursor_;

// We must manually reference count the number of users of |cursor_manager_|

// because the cursors created by |cursor_manager_| are shared among the