chrome/common/extensions/api/app_window.idl - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to explain logic behind posting instead of directly handling keyboard events. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_window_intercept_all_keys_uitest.cc ('K') | « chrome/common/extensions/api/app_current_window_internal.idl ('k') | chrome/common/extensions/permissions/chrome_api_permissions.cc » ('j') | ui/views/widget/desktop_aura/desktop_keyboard_capture_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/app_window.idl

diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl

index e5055c2cbcc41c4a39b98c4e892388d976eb3a32..929b52af27a1cf683695fe467b09bbd7081d561a 100644

--- a/chrome/common/extensions/api/app_window.idl

+++ b/chrome/common/extensions/api/app_window.idl

@@ -369,6 +369,12 @@ namespace app.window {

// TODO(jackhou): Document this properly before going to stable.

[nodoc] static boolean alphaEnabled();

+ // Set whether the window should get all keyboard events including system

+ // keys that are usually not sent. This is best-effort subject to platform

+ // specific constraints. Requires the <code>"app.window.allKeys"</code>

+ // permission. This is currently available only in dev channel on Windows.

+ static void setInterceptAllKeys(boolean wantAllKeys);

// The JavaScript 'window' object for the created child.

[instanceOf=Window] object contentWindow;