chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to explain logic behind posting instead of directly handling keyboard events. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_window_intercept_all_keys_uitest.cc ('K') | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views.h » ('j') | ui/views/widget/desktop_aura/desktop_keyboard_capture_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

index d5ed141700490337fffb8388edede175402a7694..745236f9ee0cc665dbbaebd92ba1ad71cb7309d8 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

@@ -994,6 +994,11 @@ void NativeAppWindowCocoa::SetAlwaysOnTop(bool always_on_top) {

NSNormalWindowLevel)];

}

+void NativeAppWindowCocoa::SetInterceptAllKeys(bool want_all_key) {

+ // TODO(sriramsr): implement for OSX (http://crbug.com/166928).

+ NOTIMPLEMENTED();

NativeAppWindowCocoa::~NativeAppWindowCocoa() {

}