chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to explain logic behind posting instead of directly handling keyboard events. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/apps/app_window_intercept_all_keys_uitest.cc ('K') | « chrome/browser/apps/app_window_intercept_all_keys_uitest.cc ('k') | chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc » ('j') | ui/views/widget/desktop_aura/desktop_keyboard_capture_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h

diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h

index 1af11ff78985274d5b3b6415d7760e53cbff2c82..e7d3e067502d7616460d38965fa0574fd9db46c6 100644

--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h

+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.h

@@ -199,6 +199,17 @@ class AppCurrentWindowInternalSetAlwaysOnTopFunction

virtual bool RunWithWindow(apps::AppWindow* window) OVERRIDE;

};

+class AppCurrentWindowInternalSetInterceptAllKeysFunction

+ : public AppCurrentWindowInternalExtensionFunction {

+ public:

+ DECLARE_EXTENSION_FUNCTION("app.currentWindowInternal.setInterceptAllKeys",

+ APP_CURRENTWINDOWINTERNAL_SETINTERCEPTALLKEYS)

+ protected:

+ virtual ~AppCurrentWindowInternalSetInterceptAllKeysFunction() {}

+ virtual bool RunWithWindow(apps::AppWindow* window) OVERRIDE;

+};

} // namespace extensions

#endif // CHROME_BROWSER_EXTENSIONS_API_APP_CURRENT_WINDOW_INTERNAL_APP_CURRENT_WINDOW_INTERNAL_API_H_