chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on sky's comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc ('K') | « chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc ('k') | chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm » ('j') | chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

index 5f67d0b04ee6b6dca8ae5ce4eecb9ce7e9c6252c..45a0d1698978cda9b17df53472e2e52d5bf30375 100644

--- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h

@@ -141,6 +141,7 @@ class NativeAppWindowCocoa : public apps::NativeAppWindow,

virtual SkColor InactiveFrameColor() const OVERRIDE;

virtual gfx::Insets GetFrameInsets() const OVERRIDE;

virtual bool CanHaveAlphaEnabled() const OVERRIDE;

+ virtual void SetInterceptAllKeys(bool want_all_keys) OVERRIDE;

// These are used to simulate Mac-style hide/show. Since windows can be hidden

// and shown using the app.window API, this sets is_hidden_with_app_ to