extensions/browser/app_window/app_window.h - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.h

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on Ananta's CR comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc ('K') | « extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window.h

diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h

index 5cbe8faa6932fe91d10a23af756f3484c9b7c726..ae82cdeadae0e056898232fb626d5d64fcb651ab 100644

--- a/extensions/browser/app_window/app_window.h

+++ b/extensions/browser/app_window/app_window.h

@@ -336,6 +336,10 @@ class AppWindow : public content::NotificationObserver,

// may be false if the bit is silently switched off for security reasons.

bool IsAlwaysOnTop() const;

+ // Set whether the window should get even reserved keys (modulo platform

+ // restrictions).

+ void SetInterceptAllKeys(bool want_all_keys);

// Retrieve the current state of the app window as a dictionary, to pass to

// the renderer.

void GetSerializedState(base::DictionaryValue* properties) const;