chrome/common/extensions/permissions/chrome_api_permissions.cc - Issue 297123002: API proposal for chrome.app.window to intercept all keys.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_api_permissions.cc

Issue 297123002: API proposal for chrome.app.window to intercept all keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update based on Ben's CR comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/apps/keyboard_hook_handler_win.cc ('K') | « chrome/chrome_tests.gypi ('k') | chrome/test/data/extensions/platform_apps/window_api_intercept_all_keys/has_permission/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_api_permissions.cc

diff --git a/chrome/common/extensions/permissions/chrome_api_permissions.cc b/chrome/common/extensions/permissions/chrome_api_permissions.cc

index d17bd96e7e9e2b22c5005982cb3a67be2ce51ba5..02ba7b41e6b641a770d83d71a423f5db7fee280f 100644

--- a/chrome/common/extensions/permissions/chrome_api_permissions.cc

+++ b/chrome/common/extensions/permissions/chrome_api_permissions.cc

@@ -118,8 +118,10 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

IDS_EXTENSION_PROMPT_WARNING_COPRESENCE,

PermissionMessage::kCopresence},

{APIPermission::kCopresencePrivate, "copresencePrivate"},

- {APIPermission::kDocumentScan, "documentScan",

- APIPermissionInfo::kFlagNone, IDS_EXTENSION_PROMPT_WARNING_DOCUMENT_SCAN,

+ {APIPermission::kDocumentScan,

+ "documentScan",

+ APIPermissionInfo::kFlagNone,

+ IDS_EXTENSION_PROMPT_WARNING_DOCUMENT_SCAN,

PermissionMessage::kDocumentScan},

{APIPermission::kEnterprisePlatformKeys, "enterprise.platformKeys"},

{APIPermission::kFileBrowserHandler,

@@ -414,6 +416,11 @@ std::vector<APIPermissionInfo*> ChromeAPIPermissions::GetAllPermissions()

{APIPermission::kAudio, "audio"},

{APIPermission::kCastStreaming, "cast.streaming"},

{APIPermission::kBrowser, "browser"},

+ {APIPermission::kInterceptAllKeys,

+ "app.window.interceptAllKeys",

+ APIPermissionInfo::kFlagNone,

+ IDS_EXTENSION_PROMPT_WARNING_INTERCEPT_ALL_KEYS,

+ PermissionMessage::kInterceptAllKeys},

// Settings override permissions.

{APIPermission::kHomepage,