API proposal for chrome.app.window to intercept all keys.

extensions/browser/app_window/app_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 224 matching lines @@
       window_type_(WINDOW_TYPE_DEFAULT),
       app_delegate_(app_delegate),
       image_loader_ptr_factory_(this),
       fullscreen_types_(FULLSCREEN_TYPE_NONE),
       show_on_first_paint_(false),
       first_paint_complete_(false),
       has_been_shown_(false),
       can_send_events_(false),
       is_hidden_(false),
       cached_always_on_top_(false),
-      requested_alpha_enabled_(false) {
+      requested_alpha_enabled_(false),
+      cached_want_all_keys_(false) {
   ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
   CHECK(!client->IsGuestSession(context) || context->IsOffTheRecord())
       << "Only off the record window may be opened in the guest mode.";
 }
 
 void AppWindow::Init(const GURL& url,
                      AppWindowContents* app_window_contents,
                      const CreateParams& params) {
   // Initialize the render interface and web contents
   app_window_contents_.reset(app_window_contents);
@@ skipping 85 matching lines @@
     // that to happen, we need to define a size for the content, otherwise the
     // layout will happen in a 0x0 area.
     gfx::Insets frame_insets = native_app_window_->GetFrameInsets();
     gfx::Rect initial_bounds = new_params.GetInitialWindowBounds(frame_insets);
     initial_bounds.Inset(frame_insets);
     app_delegate_->ResizeWebContents(web_contents, initial_bounds.size());
   }
 }
 
 AppWindow::~AppWindow() {
+  if (cached_want_all_keys_) {

[benwells, 2014/11/21 00:52:01]

Why is this necessary? Shouldn't the new WidgetObserver you've created get
destroyed in this case and clear all it needs to clear?

[Sriram, 2014/11/21 05:35:21]

Done.

+    native_app_window_->SetInterceptAllKeys(false);
+    cached_want_all_keys_ = false;
+  }
 }
 
 void AppWindow::RequestMediaAccessPermission(
     content::WebContents* web_contents,
     const content::MediaStreamRequest& request,
     const content::MediaResponseCallback& callback) {
   DCHECK_EQ(AppWindow::web_contents(), web_contents);
   helper_->RequestMediaAccessPermission(request, callback);
 }
 
@@ skipping 342 matching lines @@
   // overlap the taskbar to be on top. The property will be applied when the
   // window exits fullscreen and moves away from the taskbar.
   if (!IsFullscreen() && !IntersectsWithTaskbar())
     native_app_window_->SetAlwaysOnTop(always_on_top);
 
   OnNativeWindowChanged();
 }
 
 bool AppWindow::IsAlwaysOnTop() const { return cached_always_on_top_; }
 
+void AppWindow::SetInterceptAllKeys(bool want_all_keys) {
+  if (cached_want_all_keys_ != want_all_keys) {
+    native_app_window_->SetInterceptAllKeys(want_all_keys);
+    cached_want_all_keys_ = want_all_keys;
+  }
+}
+
 void AppWindow::WindowEventsReady() {
   can_send_events_ = true;
   SendOnWindowShownIfShown();
 }
 
 void AppWindow::GetSerializedState(base::DictionaryValue* properties) const {
   DCHECK(properties);
 
   properties->SetBoolean("fullscreen",
                          native_app_window_->IsFullscreenOrPending());
@@ skipping 365 matching lines @@
         region.bounds.x(),
         region.bounds.y(),
         region.bounds.right(),
         region.bounds.bottom(),
         region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
   }
   return sk_region;
 }
 
 }  // namespace extensions